Add unit tests for check_swapped_emails#3777
Open
Inengs wants to merge 2 commits intoaugurlabs:mainfrom
Open
Conversation
Signed-off-by: Inengiye Emmanuel <[email protected]>
Collaborator
|
Can you include a test for what happens if theres multiple @ signs in an email address? found this case in the wild in https://github.com/chaoss/augur commit 36aab5b |
Author
|
Alright I'll do that, thank you |
Signed-off-by: Inengiye Emmanuel <[email protected]>
Author
|
I have made the change I am open to making any more changes, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
check_swapped_emailsfunction inanalyzecommit.pyTests cover:
This PR fixes #3741
I think the function needs to be made more robust, because it cant distinguish between a real email and a mixed string containing both name and email.
Notes for Reviewers
Signed commits